Make FigureManagerWx more consistent with other backends. #13153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
commented
Jan 10, 2019
| window : wxFrame | ||
| a wxFrame instance - wxpython.org/Phoenix/docs/html/Frame.html |
There was a problem hiding this comment.
The link is broken and if anything the only link should be to the wxpython general docs at the top of the module (perhaps).
7e54812 to
0986dad
Compare
|
Because wx expects (AFAIU) parent widgets to be fully set up before children, I don't think it is possible to match the model of other backends where we first create the Canvas and then let the Manager create the toplevel window that hosts it :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Builds on top of #13146 to avoid a rebase.Note that unlike in #10606, FigureManagerWx is a pure-python class, not a wx Widget, so there's no problems with wxness of the constructor there.
PR Checklist