Slightly rework animation logging. #13161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklymak
approved these changes
Jan 11, 2019
QuLogic
reviewed
Jan 12, 2019
- Only log ffmpeg stdout/stderr if it outputted something on that stream. This avoids a spurious empty stdout log when the entire interesting part is on stderr. - Improve the writer-fallback logic (right now the IndexError clause is never going to be executed as the IndexError is first raised (if writers.list() is empty) in the log.warning call, before the try: ...).
timhoffm
approved these changes
Jan 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stream. This avoids a spurious empty stdout log when the entire
interesting part is on stderr. (Let ffmpeg report errors. #13155 for an example use case.)
never going to be executed as the IndexError is first raised (if
writers.list() is empty) in the log.warning call, before the try:
...).
PR Summary
PR Checklist