Change doc string for Axes.arrow() #13165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the string from "The x/y-coordinate of the arrow base" to "The x and y coordinates of the arrow base".
timhoffm
reviewed
Jan 12, 2019
lib/matplotlib/axes/_axes.py
Outdated
| @@ -4795,7 +4795,7 @@ def arrow(self, x, y, dx, dy, **kwargs): | |||
| Parameters | |||
| ---------- | |||
| x, y : float | |||
| The x/y-coordinate of the arrow base. | |||
| The x and y coordinates of the arrow base. | |||
| dx, dy : float | |||
| The length of the arrow along x/y-direction. | |||
There was a problem hiding this comment.
If we remove x/y notation, please change this as well.
There was a problem hiding this comment.
Done. Would you recommend changing it in other places like here
changed "x/y" to "x and y"
timhoffm
approved these changes
Jan 12, 2019
|
Can we edit the title of this PR to something that doesnt reference source code line numbers? Otherwise looks great! Thanks. |
|
👍 thanks a lot for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the string from "The x/y-coordinate of the arrow base" to "The x and y coordinates of the arrow base".
PR Summary
PR Checklist