Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Simplify Text.get_usetex. #13166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2019
Merged

Simplify Text.get_usetex. #13166

merged 1 commit into from
Jan 15, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jan 12, 2019

  • Make the module-level _wrap_text a text method instead, and don't make
    it yield anything as it is modifying the text object in-place anyways.
    (This avoids having to wonder where other textobj attributes come
    from.)
    Removed this as I realized there's an even simpler way to handle
    it, but would be better on top of Make Text._get_layout simpler to follow. #12951.
  • text._usetex is never None because set_usetex already replaces
    None by the rc value, so we don't need to additionally validate in the
    getter.

Preliminary work towards fixing #13139 (comment) (#12951 would be needed too to avoid a rebase).

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer changed the title Preparatory Text cleanups. Simplify Text.get_usetex. Jan 12, 2019
set_usetex already prevents `self._usetex` to even be None.
@jklymak jklymak merged commit 5a7e0ea into matplotlib:master Jan 15, 2019
@anntzer anntzer deleted the text branch January 15, 2019 18:22
@QuLogic QuLogic added this to the v3.1 milestone Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants