Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove signatures that duplicate introspectable data. #13177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 19, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jan 14, 2019

(For the case of Axes.table, one can just directly use the
matplotlib.table.table function as the method.)

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer force-pushed the signatures branch 2 times, most recently from df1d6ef to fd7e88e Compare January 14, 2019 07:26
Copy link
Member

@efiring efiring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a nice cleanup.

@anntzer anntzer force-pushed the signatures branch 2 times, most recently from 7391202 to 5013b97 Compare January 17, 2019 10:55
@@ -669,15 +669,15 @@ def _single_spectrum_helper(x, mode, Fs=None, window=None, pad_to=None,
This should *NOT* be used to get zero padding, or the scaling of the
result will be incorrect. Use *pad_to* for this instead.

detrend : {'default', 'constant', 'mean', 'linear', 'none'} or callable
detrend : {'none', 'mean', 'linear'} or callable, default 'none'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(For the case of Axes.table, one can just directly use the
`matplotlib.table.table` function as the method.)
@jklymak jklymak merged commit 15c1c47 into matplotlib:master Jan 19, 2019
@anntzer anntzer deleted the signatures branch January 19, 2019 10:23
@QuLogic QuLogic added this to the v3.1.0 milestone Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants