Simplify and optimize png writing in backend_pdf. #13247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old code would first read into a bytesarray, and then create a copy by calling bytes() on it. Don't bother with the copy. Also, `written` is unused.
QuLogic
approved these changes
Jan 21, 2019
|
It's really just an assertion error that I don't expect to be ever triggered. If it does happen and someone is confused, we'll revisit it... |
jklymak
approved these changes
Jan 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old code would first read into a bytesarray, and then create a copy
by calling bytes() on it. Don't bother with the copy.
Also,
writtenis unused.PR Summary
PR Checklist