Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Replace *kw by *args. #13310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 29, 2019
Merged

Replace *kw by *args. #13310

merged 1 commit into from
Jan 29, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jan 28, 2019

and, when it occurs in the same file, **kw by **kwargs.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Replace *kw by *args.
ac5d377 
and, when it occurs in the same file, `**kw` by `**kwargs`.
@WeatherGod
Copy link
Member

Huh, I wonder how kl was ever a thing?

WeatherGod
WeatherGod approved these changes Jan 28, 2019
View reviewed changes
Copy link
Member

@WeatherGod WeatherGod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, assuming that the tests runs fine. I only checked that what changed makes sense, but I didn't check that everything that should have been changed did get changed (hopefully the tests should catch that).

timhoffm
timhoffm approved these changes Jan 28, 2019
View reviewed changes
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anybody can merge after CI pass.

@QuLogic QuLogic added this to the v3.1 milestone Jan 29, 2019
@tacaswell tacaswell merged commit 33eeb8b into matplotlib:master Jan 29, 2019
@anntzer anntzer deleted the kl branch January 29, 2019 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WeatherGod WeatherGod WeatherGod approved these changes

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@anntzer @WeatherGod @QuLogic @timhoffm @tacaswell