Cleanup ScalarFormatter; preparatory to moving it to format_ticks. #13324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScalarFormatter.set_locs calls a bunch of helper methods with arguments that the helpers can reconstruct themselves based on axis.get_view_interval(); in fact they *already* call axis.get_view_interval() at certain places. So get rid of these arguments. ScalarFormatter._compute_offset is only ever called by set_locs, and only if len(locs) > 0, so the `locs is None or not len(locs)` condition is never True.
timhoffm
approved these changes
Feb 1, 2019
jklymak
approved these changes
Feb 1, 2019
|
I think this is fine, and the Appveyor job just flaked out... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ScalarFormatter.set_locs calls a bunch of helper methods with arguments
that the helpers can reconstruct themselves based on
axis.get_view_interval(); in fact they already call
axis.get_view_interval() at certain places. So get rid of these
arguments.
ScalarFormatter._compute_offset is only ever called by set_locs, and
only if len(locs) > 0, so the
locs is None or not len(locs)conditionis never True.
PR Summary
PR Checklist