Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Deprecate axis3d.Axis.get_tick_positions. #13373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 6, 2019
Merged

Deprecate axis3d.Axis.get_tick_positions. #13373

merged 1 commit into from
Feb 6, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Feb 5, 2019

See changelog entry for rationale.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Deprecate axis3d.Axis.get_tick_positions.
28fb185 
See changelog entry for rationale.
@anntzer anntzer force-pushed the get_tick_positions branch from a3801b5 to 28fb185 Compare February 6, 2019 00:07
WeatherGod
WeatherGod approved these changes Feb 6, 2019
View reviewed changes
Copy link
Member

@WeatherGod WeatherGod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. Just went as far back as the original mplot3d commit and it has never been used. Perhaps it was originally a typo and it never worked?

@jklymak jklymak merged commit aab3e8a into matplotlib:master Feb 6, 2019
@jklymak jklymak added this to the v3.1.0 milestone Feb 6, 2019
@anntzer anntzer deleted the get_tick_positions branch February 6, 2019 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WeatherGod WeatherGod WeatherGod approved these changes

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
topic: mplot3d
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @WeatherGod @jklymak