Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Minor simplifications to scatter3d. #13380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2019
Merged

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Feb 7, 2019

The lines

        xs, ys, zs = np.broadcast_arrays(
            *[np.ravel(np.ma.filled(t, np.nan)) for t in [xs, ys, zs]])

at the top of the function ensure that zs is already broadcasted against
xs, and always 1D (and thus iterable); hence, the later iterability check
and broadcasting are unnecessary.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

The lines
```
        xs, ys, zs = np.broadcast_arrays(
            *[np.ravel(np.ma.filled(t, np.nan)) for t in [xs, ys, zs]])
```
at the top of the function ensure that zs is already broadcasted against
xs, and always 1D (and thus iterable); hence, the later iterability check
and broadcasting are unnecessary.
@timhoffm timhoffm merged commit 2d05981 into matplotlib:master Feb 7, 2019
@timhoffm timhoffm added this to the v3.1.0 milestone Feb 7, 2019
@anntzer anntzer deleted the scatter3d branch February 7, 2019 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants