Deprecate axes_grid1.colorbar (in favor of matplotlib's own). #13397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2e3633b to
13cc45e
Compare
jklymak
reviewed
Feb 16, 2019
| # The original version of this test relied on mpl_toolkits's slightly different | ||
| # colorbar implementation; moving to matplotlib's own colorbar implementation | ||
| # caused the small image comparison error. | ||
| @pytest.mark.parametrize("legacy_colorbar", [False, True]) |
There was a problem hiding this comment.
You don't want to just change the image?
Otherwise, I'm onboard for this!
There was a problem hiding this comment.
You know I really, really don't like adding/changing baseline images... hence the check_images_equal decorator, etc.
There was a problem hiding this comment.
This parametrization makes the test flaky in parallel, as one can overwrite the test file of another process. We only use duplicate file names in the image_comparison decorator for that reason.
13cc45e to
8be8810
Compare
8be8810 to
e9a4166
Compare
05127ec to
d43cb34
Compare
See changelog note for rationale (looks like the mpl_toolkits colorbar implementation was copy-pasted a while ago, and then did not get most of the recent improvements to matplotlib's colorbar). May be worth adding a property to the builtin colorbar similar to mpl_toolkit's `cbar_axis` (pointing to whichever of `xaxis` or `yaxis` is the long axis). I don't think supporting overdrawing multiple colorbars on a single Axes is really worth it. Manual examination of axisartist/axes_grid1 examples that use colorbars show no difference.
d43cb34 to
9a8ec76
Compare
efiring
approved these changes
Aug 19, 2019
tacaswell
approved these changes
Aug 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See changelog note for rationale (looks like the mpl_toolkits colorbar
implementation was copy-pasted a while ago, and then did not get most of
the recent improvements to matplotlib's colorbar).
May be worth adding a property to the builtin colorbar similar to
mpl_toolkit's
cbar_axis(pointing to whichever ofxaxisoryaxisis the long axis).
I don't think supporting overdrawing multiple colorbars on a single Axes
is really worth it.
Manual examination of axisartist/axes_grid1 examples that use colorbars
show no difference.
PR Summary
PR Checklist