Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix empty reshape2d #13402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 11, 2019
Merged

Fix empty reshape2d #13402

merged 2 commits into from
Feb 11, 2019

Conversation

jklymak
Copy link
Member

@jklymak jklymak commented Feb 10, 2019

PR Summary

Closes #13392 for plt.boxplt([]).

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@jklymak jklymak added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Feb 10, 2019
@jklymak jklymak added this to the v3.0.3 milestone Feb 10, 2019
@jklymak jklymak force-pushed the fix-empty-reshape2d branch from a00e4d8 to fd04f2d Compare February 10, 2019 23:44
@jklymak
Copy link
Member Author

jklymak commented Feb 10, 2019

Release Critical because this was apparently a regression (which @anntzer blames on me, but all I did was unbreak part of a PR he did 😉)

@jklymak
Copy link
Member Author

jklymak commented Feb 11, 2019

The test failures are specious...

@tacaswell tacaswell merged commit 56755e4 into matplotlib:master Feb 11, 2019
@lumberbot-app
Copy link

lumberbot-app bot commented Feb 11, 2019

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.0.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 56755e44e894088624020006130ad3706ea5a330
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #13402: Fix empty reshape2d'
  1. Push to a named branch :
git push YOURFORK v3.0.x:auto-backport-of-pr-13402-on-v3.0.x
  1. Create a PR against branch v3.0.x, I would have named this PR:

"Backport PR #13402 on branch v3.0.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

@jklymak jklymak deleted the fix-empty-reshape2d branch February 11, 2019 05:06
@tacaswell tacaswell modified the milestones: v3.0.3, v3.1.0 Feb 11, 2019
@tacaswell tacaswell removed Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. status: needs manual backport labels Feb 11, 2019
@tacaswell
Copy link
Member

Despite the nudges from git, we should try to avoid personal blame in our discussions.

I don't think we have to backport this as the PR that introduced the regression has not been released yet.

@jklymak
Copy link
Member Author

jklymak commented Feb 11, 2019

Apologies - couldn't resist!

@anntzer
Copy link
Contributor

anntzer commented Feb 11, 2019

It's totally fine :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.

boxplot broken for empty inputs
3 participants
@jklymak @tacaswell @anntzer