Register 3d projection by default. #13520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
tacaswell
reviewed
Feb 26, 2019
| @@ -70,3 +73,7 @@ def get_projection_names(): | |||
| Get a list of acceptable projection names. | |||
| """ | |||
| return projection_registry.get_projection_names() | |||
|
|
|||
|
|
|||
| # Register Axes3D. | |||
There was a problem hiding this comment.
Don't think we need this any more?
There was a problem hiding this comment.
oops, indeed, fixed
Now that we always install mpl_toolkits, we may as well always register mplot3d and save an "apparently unused" import for the users.
|
they passed |
timhoffm
approved these changes
Feb 27, 2019
6 tasks
|
Worth a backport to |
6 tasks
|
Examining the output of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we always install mpl_toolkits (#12317), we may as well always register
mplot3d and save an "apparently unused" import for the users (#12249).
PR Summary
PR Checklist