DOC: fix Subplot calls #13526
DOC: fix Subplot calls #13526
Conversation
|
anyone can merge post ci |
|
@anntzer do you understand where Subplot comes from? |
|
FYI you should also be able to remove the |
|
That's the subclass of Axes actually returned by add_subplot(), but in practice no one ever calls it directly. |
|
|
||
| # the following syntax is the same as above, except perhaps more convenient: | ||
| gs01 = gs0[1].subgridspec(3, 3) | ||
|
|
There was a problem hiding this comment.
Can you remove this newline and the one after gs00 above? Or add a comment above gs00?
When I first read the comment about "same as above", I thought it was about add_subplot, but it's really talking about the gridspec.GridSpecFromSubplotSpec(...).
There was a problem hiding this comment.
Rephrased to # the following syntax does the same as the GridSpecFromSubplotSpec call above:
85a3ee5 to
899cdf6
Compare
899cdf6 to
e587e5e
Compare
…526-on-v3.1.x Backport PR #13526 on branch v3.1.x (DOC: fix Subplot calls)
PR Summary
There were a few calls to
plt.Subplotthat confused the doc builds (and me! See long discussion sphinx-gallery/sphinx-gallery#448). I don't even understand how those calls worked, sincepyplotdoes not have anything defined asSubplot. But basically they clobbered thepyplot.subplotgallery tracking. Changed these instances toadd_subplotand all seems to build fine.PR Checklist