Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Move {setup,install}_requires from setupext.py to setup.py. #13542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Feb 28, 2019

The Numpy class in setupext.py serves two purposes: declare a
setup_requires and an install_requires on numpy, and provide a
add_flags() (effectively static) method to link extension modules to
numpy.

Instead, we can just merge the setup and install_requires together
with all other install_requires, and move all of them to setup.py
(deleting the machinery to grab setup_requires and install_requires
from multiple places), and make the add_flags() method a free function
(add_numpy_flags()).

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added the Build label Feb 28, 2019
@jklymak jklymak added this to the v3.2.0 milestone Feb 28, 2019
The Numpy class in setupext.py serves two purposes: declare a
setup_requires and an install_requires on numpy, and provide a
add_flags() (effectively static) method to link extension modules to
numpy.

Instead, we can just merge the setup and install_requires together
with all other install_requires, and move all of them to setup.py
(deleting the machinery to grab setup_requires and install_requires
from multiple places), and make the add_flags() method a free function
(add_numpy_flags()).
Copy link
Member

@efiring efiring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a setup expert by any means, but this looks good to me.

@efiring efiring requested a review from QuLogic May 26, 2019 00:06
@tacaswell tacaswell merged commit 4ce649c into matplotlib:master May 26, 2019
@anntzer anntzer deleted the numpy_requires branch May 26, 2019 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants