Fix IndexError for pyplot.legend() when plotting empty bar chart with label #13551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklymak
approved these changes
Mar 1, 2019
jklymak
reviewed
Mar 2, 2019
lib/matplotlib/tests/test_legend.py
Outdated
| @@ -477,6 +477,14 @@ def test_handler_numpoints(): | |||
| ax.legend(numpoints=0.5) | |||
|
|
|||
|
|
|||
| @image_comparison(baseline_images=['empty_bar_legend'], extensions=['svg']) | |||
There was a problem hiding this comment.
OK, this is failing because your the baseline image is a different size. But...
- try not to use svg for this sort of thing because we just rasterize to png anyway.
- we try not to do image comparisons if possible because they are expensive in terms of time and bandwidth. Its my undertstanding this crashed before, so all you need for this to pass is for this not to crash (i.e. a smoketest). Suggest you simply remove the image comaprison
There was a problem hiding this comment.
I would say just get rid of the image comparison and the test image, I think it's good enough to just check the code runs without any errors.
There was a problem hiding this comment.
Thank you for your comments. I will keep that in mind. In the future, how would I do image comparisons? I created the image using save_fig and it seems to output in a different dimension.
There was a problem hiding this comment.
I usually run the tests locally (make sure that in setup.cfg you have compiled so that freetype is local) and then copy the resulting image into the baseline images...
dstansby
approved these changes
Mar 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Resolves #13003. Allows an empty bar chart to be created with a legend.
PR Checklist