Fix font deduplication logic in createFontList. #13678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only add a font name to the "seen" list if one successfully extracts the font properties from it; otherwise a first font that cannot be read (e.g. due to permission issues) will mask a later font that can.
timhoffm
approved these changes
Mar 16, 2019
QuLogic
approved these changes
Mar 17, 2019
|
Probably should put it on 3.1.0, so... @meeseeksdev backport to v3.1.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Mar 17, 2019
timhoffm
added a commit
that referenced
this pull request
Mar 17, 2019
…678-on-v3.1.x Backport PR #13678 on branch v3.1.x (Fix font deduplication logic in createFontList.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only add a font name to the "seen" list if one successfully extracts the
font properties from it; otherwise a first font that cannot be read
(e.g. due to permission issues) will mask a later font that can.
I think this should close(?) #13673.
PR Summary
PR Checklist