Kill attributes that are never used/updated. #13716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kill the private ones and deprecate the public ones (most of them are leftovers from (very) old refactors).
timhoffm
approved these changes
Mar 23, 2019
|
Moving to 3.1 to get the deprecation period running. Feel free to re-milestone if this is not merged when 3.1 will be released. |
QuLogic
approved these changes
Mar 24, 2019
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Mar 24, 2019
timhoffm
added a commit
that referenced
this pull request
Mar 24, 2019
…716-on-v3.1.x Backport PR #13716 on branch v3.1.x (Kill attributes that are never used/updated.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kill the private ones and deprecate the public ones (most of them are
leftovers from (very) old refactors).
PR Summary
PR Checklist