-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Deprecate plotfile. #13740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate plotfile. #13740
Conversation
I see no consensus in that issue to deprecate plotfile(). Based on
thumbs-up, we seem to be even split on deprecating versus reimplementing
using numpy functions.
…On Fri, Mar 22, 2019 at 2:37 PM Antony Lee ***@***.***> wrote:
as discussed in #12180
<#12180>.
Various replacements are showcased in plotfile_demo_sgskip.
PR Summary PR Checklist
- Has Pytest style unit tests
- Code is Flake 8 <http://flake8.pycqa.org/en/latest/> compliant
- New features are documented, with examples if plot related
- Documentation is sphinx and numpydoc compliant
- Added an entry to doc/users/next_whats_new/ if major new feature
(follow instructions in README.rst there)
- Documented in doc/api/api_changes.rst if API changed in a
backward-incompatible way
------------------------------
You can view, comment on, or merge this pull request online at:
#13740
Commit Summary
- Deprecate plotfile.
File Changes
- *A* doc/api/next_api_changes/2019-03-23-AL.rst
<https://github.com/matplotlib/matplotlib/pull/13740/files#diff-0> (7)
- *D* examples/misc/plotfile_demo.py
<https://github.com/matplotlib/matplotlib/pull/13740/files#diff-1>
(45)
- *A* examples/misc/plotfile_demo_sgskip.py
<https://github.com/matplotlib/matplotlib/pull/13740/files#diff-2>
(89)
- *M* examples/tests/backend_driver_sgskip.py
<https://github.com/matplotlib/matplotlib/pull/13740/files#diff-3> (1)
- *M* lib/matplotlib/pyplot.py
<https://github.com/matplotlib/matplotlib/pull/13740/files#diff-4> (1)
Patch Links:
- https://github.com/matplotlib/matplotlib/pull/13740.patch
- https://github.com/matplotlib/matplotlib/pull/13740.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#13740>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AARy-HOle9Y9lLCiL2QFokhCxDlSROEWks5vZSLVgaJpZM4cEMGT>
.
|
Deprecating vs rewriting was 50/50. I was for deprecating because Disregarding my personal preference, something has to be done about |
plotfile demo | ||
============= | ||
|
||
Replacing the deprecated `plotfile` by pandas or other matplotlib plotting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anntzer This is really a bit difficult to follow. At first glance I was just seeing plotfile
all over the place. Are you happy with me rewriting the example to better explain/structure it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@timhoffm go for it.
I'll officially change my "vote" in #12180. I think IF an example is changed, I'd prefer the example uses |
@anntzer can you please rebase on top of master. I'm not sure if I would break things for you if I rebase and then add a commit to enhance the example. |
Various replacements are showcased in plotfile_demo_sgskip.
rebased |
Added some more explanation. Once |
I'll put in a vote for deprecation:
So I'm with @timhoffm. Also, if we deprecate and people scream, we can revisit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sooner, the better...
@timhoffm Are there critical changes needed for this, or can it be merged as-is? |
From my side, this is good enough. We've added a number of examples how to achieve the same functionality as |
as discussed in #12180.
Various replacements are showcased in plotfile_demo_sgskip.
PR Summary
PR Checklist