Autoscale for ax.arrow() #13788
Closed
Autoscale for ax.arrow() #13788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In view of #11350 I'd be interested to know what use case people have for |
dstansby
requested changes
Aug 14, 2019
|
Looking forward to this fix ! thanks |
|
This will also need an API change note. There are likely users who are relying on this not auto-scaling and they need to be notified. |
4 tasks
|
@liujordan please don't give up ! I want your fix :p |
|
Taking over from @liujordan. This was previously a student project at University of Toronto Scarborough with Dr. Anya Tafliovich (@atafliovich). |
|
A major change I made was removing the |
anntzer
requested changes
Oct 1, 2019
|
Looks like something went wrong with the rebase? :( |
|
Trying to fix it now. |
|
I was unable to fix this branch, so restarted in another PR #15392 |
|
Closing for other pr |
teto
added a commit
to teto/pymptcpanalyzer
that referenced
this pull request
Oct 25, 2019
can try mptcpanalyzer -dDEBUG "plot dss examples/client_2_filtered.pcapng 1 --dest=Server" "quit" There is an issue with autoscaling not working because FancyArrows are drawn as artists rather than patches see matplotlib/matplotlib#13788
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
When ax.arrow() is called, a FancyArrow object is being added to the current axes as an artist and not a patch. So when autoscale_view is called, which loops through all Patches and scales the view based on the minimum and maximum of those, the FancyArrow isn't being considered.
The solution is a two-step process. First, we have to add the arrow as a Patch, and second, we have to call autoscale_view() after adding it on the axes.
Resolves #12712
PR Checklist