Thanks to visit codestin.com
Credit goes to github.com

Skip to content

3.1.0 API changes page #13870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Apr 15, 2019
Merged

3.1.0 API changes page #13870

merged 27 commits into from
Apr 15, 2019

Conversation

dstansby
Copy link
Member

@dstansby dstansby commented Apr 3, 2019

This will hopefully turn into the final 3.1.0 API changes page.

In addition to merging the API changes I have slightly changed how they are shown. Instead of putting all the text at the bottom of /api/api_changes.html, I have created a separate 3.1.0 page with the rest of the version changes, and just included it in the /api/api_changes.html page. This means

  • No having to manually move these changes in the next version to a new file
  • /api/api_changes_old.html contains a complete (including latest version) list of changes

@dstansby dstansby added Documentation Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. labels Apr 4, 2019
@tacaswell tacaswell added this to the v3.1.0 milestone Apr 4, 2019
@tacaswell
Copy link
Member

@dstansby Hope you do not mind I pushed some commits, should have asked first 😞

@dstansby
Copy link
Member Author

dstansby commented Apr 7, 2019

No problem at all!

@dstansby dstansby marked this pull request as ready for review April 11, 2019 11:55
@dstansby dstansby closed this Apr 11, 2019
@dstansby dstansby reopened this Apr 11, 2019
@dstansby
Copy link
Member Author

Reorganising this into something coherent is done now, if anyone has the energy to proof read it please do... @matplotlib/developers


This will only affect cases where that parameter has been set
as a keyword argument. The common usage pattern as a positional argument
``matplotlib.use('Qt5Agg')`` is not affected.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this paragraph need to be indented to match the enumeration pattern?


This has never been used internally, there is no equivalent method exists on
the 2D Axis classes, and despite the similar name, it has a completely
different behavior from the 2D Axis' `axis.Axis.get_ticks_position` method.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation (s.a.)?

@tacaswell
Copy link
Member

@dstansby I intend to rebase and force push this branch (to pick up #13908 to check the links are correct).

@tacaswell
Copy link
Member

If this builds cleanly I am going to merge this, we can continue to work on it during the RC cycle.

Again, thank you @dstansby !

@tacaswell tacaswell merged commit 9d8a87d into matplotlib:master Apr 15, 2019
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Apr 15, 2019
@dstansby dstansby deleted the 310api branch April 15, 2019 13:08
dstansby added a commit that referenced this pull request Apr 15, 2019
…870-on-v3.1.x

Backport PR #13870 on branch v3.1.x (3.1.0 API changes page)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants