Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add some documentation for axisartist's ExtremeFinder, plus some cleanups. #13884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2020
Merged

Add some documentation for axisartist's ExtremeFinder, plus some cleanups. #13884

merged 1 commit into from
May 23, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Apr 4, 2019 •
edited
Loading

PR Summary

Let's try to figure out how this whole thing is constructed :) At least
that PR is my understanding.

Minor refactorings as well.

Goes on top of #13878.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@tacaswell tacaswell added this to the v3.3.0 milestone Feb 11, 2020
QuLogic
QuLogic reviewed Mar 12, 2020
View reviewed changes
Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is slightly more than just documentation.

@anntzer anntzer changed the title Add some documentation for axisartist's ExtremeFinder. Add some documentation for axisartist's ExtremeFinder, plus some cleanups. Mar 12, 2020
QuLogic
QuLogic approved these changes Mar 14, 2020
View reviewed changes
@anntzer
Copy link
Contributor Author

anntzer commented Mar 14, 2020

edited

@anntzer
Add some documentation for ExtremeFinder.
bff5ce5 
Let's try to figure out how this whole thing is constructed :)  At least
that's my understanding.
@anntzer
Copy link
Contributor Author

anntzer commented Mar 31, 2020

rebased

@tacaswell tacaswell merged commit 898bd5f into matplotlib:master May 23, 2020
@anntzer anntzer deleted the docextreme branch May 23, 2020 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

Assignees
No one assigned
Labels
topic: mpl_toolkit
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @QuLogic @tacaswell @timhoffm