Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Check for positive number of rows and cols #13894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2019
Merged

Check for positive number of rows and cols #13894

merged 1 commit into from
Apr 10, 2019

Conversation

timhoffm
Copy link
Member

@timhoffm timhoffm commented Apr 6, 2019

PR Summary

Fixes #13872.

@timhoffm timhoffm force-pushed the subplot-check-nrows-ncols branch from 71d3cc3 to bc9396c Compare April 6, 2019 09:27
dstansby
dstansby reviewed Apr 6, 2019
View reviewed changes
Copy link
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could have a short test to check that asking for negative or zero rows/cols raises an error?

@tacaswell tacaswell added this to the v3.2.0 milestone Apr 7, 2019
@timhoffm timhoffm force-pushed the subplot-check-nrows-ncols branch from bc9396c to 671750c Compare April 9, 2019 17:46
@timhoffm
Copy link
Member Author

timhoffm commented Apr 9, 2019

Test added.

@timhoffm timhoffm changed the title Check for positive number or rows and cols Check for positive number of rows and cols Apr 9, 2019
@anntzer anntzer merged commit 9d3a736 into matplotlib:master Apr 10, 2019
@timhoffm timhoffm deleted the subplot-check-nrows-ncols branch April 10, 2019 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anntzer anntzer anntzer approved these changes

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
API: argument checking
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@timhoffm @anntzer @dstansby @tacaswell