Deprecate the useless switch_backend_warn parameter to matplotlib.test. #13935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matplotlib.test always calls matplotlib.use() with force set to its default value of True, which means that the warn parameter has no effect. So just don't bother passing it. Also slightly reorder the logic in use() to make this more apparent (I think?).
timhoffm
approved these changes
Apr 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
matplotlib.testalways callsmatplotlib.use()withforceset to itsdefault value of True, which means that the
warnparameter has noeffect. So just don't bother passing it.
Also slightly reorder the logic in
use()to make this more apparent (Ithink?).
PR Summary
PR Checklist