Make unicode_minus example more focused. #13945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
reviewed
Apr 13, 2019
| minus, which some people prefer. :rc:`axes.unicode_minus` controls the default | ||
| behavior. | ||
| By default, tick labels at negative values are rendered using a `Unicode | ||
| minus`__ (U+2212) rathen than an ASCII hyphen (U+002D). This can be controlled |
There was a problem hiding this comment.
Suggested change
| minus`__ (U+2212) rathen than an ASCII hyphen (U+002D). This can be controlled | |
| minus`__ (U+2212) rather than an ASCII hyphen (U+002D). This can be controlled |
timhoffm
approved these changes
Apr 14, 2019
... by actually showcasing the difference between unicode minus and ascii hyphen.
QuLogic
reviewed
Apr 15, 2019
| behavior. | ||
| By default, tick labels at negative values are rendered using a `Unicode | ||
| minus`__ (U+2212) rather than an ASCII hyphen (U+002D). This can be controlled | ||
| by setting :rc:`axes.unicode_minus` (which defaults to True). |
There was a problem hiding this comment.
This sentence seems incomplete:
Suggested change
| by setting :rc:`axes.unicode_minus` (which defaults to True). | |
| by setting :rc:`axes.unicode_minus` (which defaults to True) to False. |
There was a problem hiding this comment.
"It can be controlled by setting the rcParam (meaning, to either value)"?
There was a problem hiding this comment.
I think it is fine the way it is.
efiring
approved these changes
Apr 21, 2019
| behavior. | ||
| By default, tick labels at negative values are rendered using a `Unicode | ||
| minus`__ (U+2212) rather than an ASCII hyphen (U+002D). This can be controlled | ||
| by setting :rc:`axes.unicode_minus` (which defaults to True). |
There was a problem hiding this comment.
I think it is fine the way it is.
|
I've set the milestone post-merge to indicate which version is actually targeted by merging into the current master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... by actually showcasing the difference between unicode minus and
ascii hyphen.
PR Summary
PR Checklist