Support RGBA for quadmesh mode of pcolorfast. #13986
Conversation
66d1605 to
640258d
Compare
|
I like this and will give it a positive review ASAP, but I request that you first add a fix for a relevant documentation error that was introduced in 3e14dd2. Specifically, in the Quadmesh case, the shapes of X and Y must be (M+1, N+1), where C.shape is (M, N). Also remove the reference to pcolormesh, which is misleading in this context; the shape rules are more strict for pcolorfast than for pcolormesh. |
640258d to
793b583
Compare
|
edited the docstring accordingly. |
793b583 to
7644743
Compare
| @@ -6331,7 +6339,7 @@ def pcolorfast(self, *args, alpha=None, norm=None, cmap=None, vmin=None, | |||
|
|
|||
| if vmin is not None or vmax is not None: | |||
| ret.set_clim(vmin, vmax) | |||
| else: | |||
| elif np.ndim(C) == 2: | |||
| ret.autoscale_None() | |||
There was a problem hiding this comment.
I would add a comment
# np.dim(C) == 3 has explicit RGB(A) values and does not need scaling.
There was a problem hiding this comment.
Have you pushed? I don't see a comment.
There was a problem hiding this comment.
duh, put it at the wrong line; fixed.
7644743 to
8d0c12f
Compare
8d0c12f to
4903d36
Compare
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
|
Well, the rc is out, so I'm guessing we aren't going to slip this into 3.1.0. |
Resolved all conflicts in favor of the master branch except for the changes to doc/api/prev_api_changes/api_changes_3.1.0.rst pcolorfast was updating to take RGB(A) in some cases in PR matplotlib#8690 / 94b0bca that was backported to v3.1.x via matplotlib#13709 / afc4e61 . However, the functionality was further extended in matplotlib#13986 / c05537d which was not backported. When merging v3.1.x into master special care had to be taken to not pull the removed code back into master.
PR Summary
As pointed out by @ImportanceOfBeingErnest in https://stackoverflow.com/questions/49621655/rgb-polar-plot-in-python/49630831#49630831, pcolormesh does support (in a slightly awkward way) RGBA input, and thus pcolorfast can also support it easily.
Suggesting to still smuggle this in 3.1, as it's a natural extension over #8690...
PR Checklist