Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[BUG] DOC: Remove broken references to vischeck #14001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2019
Merged

[BUG] DOC: Remove broken references to vischeck #14001

merged 1 commit into from
Apr 25, 2019

Conversation

bharatr21
Copy link
Contributor

PR Summary

Fix #14000 by removing references to vischeck

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related (No new feature)
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there) (Not sure about this)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way (Not applicable)

@tacaswell tacaswell added this to the v3.0-doc milestone Apr 22, 2019
tacaswell
tacaswell approved these changes Apr 22, 2019
View reviewed changes
Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would like to hold of merging this until we fix the doc builds.

timhoffm
timhoffm approved these changes Apr 23, 2019
View reviewed changes
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tacaswell Can we merge or do you want a rebase to see that the doc build passes?

dstansby
dstansby approved these changes Apr 25, 2019
View reviewed changes
Copy link
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to merge, if it breaks the docs I will make a fix. Thanks a lot for the fix!

@dstansby dstansby merged commit 41d2494 into matplotlib:master Apr 25, 2019
@lumberbot-app
Copy link

lumberbot-app bot commented Apr 25, 2019

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.0.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 41d24940859ef077822e4ad3ef80bbb74b1d7f76
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #14001: [BUG] DOC: Remove broken references to vischeck'
  1. Push to a named branch :
git push YOURFORK v3.0.x:auto-backport-of-pr-14001-on-v3.0.x
  1. Create a PR against branch v3.0.x, I would have named this PR:

"Backport PR #14001 on branch v3.0.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

@lumberbot-app
Copy link

lumberbot-app bot commented Apr 25, 2019

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.0.3-doc
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 41d24940859ef077822e4ad3ef80bbb74b1d7f76
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #14001: [BUG] DOC: Remove broken references to vischeck'
  1. Push to a named branch :
git push YOURFORK v3.0.3-doc:auto-backport-of-pr-14001-on-v3.0.3-doc
  1. Create a PR against branch v3.0.3-doc, I would have named this PR:

"Backport PR #14001 on branch v3.0.3-doc"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Apr 25, 2019
@dstansby
Backport PR matplotlib#14001: [BUG] DOC: Remove broken references to …
693be61 
…vischeck
@meeseeksmachine meeseeksmachine mentioned this pull request Apr 25, 2019
Merged
timhoffm added a commit that referenced this pull request Apr 25, 2019
@timhoffm
Merge pull request #14036 from meeseeksmachine/auto-backport-of-pr-14…
5e8319a 
…001-on-v3.1.x

Backport PR #14001 on branch v3.1.x ([BUG] DOC: Remove broken references to vischeck)
@timhoffm timhoffm mentioned this pull request Apr 25, 2019
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@timhoffm timhoffm timhoffm approved these changes

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0-doc
Development

Successfully merging this pull request may close these issues.

Link to vischeck.com needs to be changed
4 participants
@bharatr21 @tacaswell @timhoffm @dstansby