Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Pretty-format subprocess logs. #14041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2019
Merged

Pretty-format subprocess logs. #14041

merged 1 commit into from
Apr 26, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Apr 25, 2019

e.g. subprocess spawned by the animation machinery are now logged as

MovieWriter._run: running command: ffmpeg -f rawvideo -vcodec rawvideo -s 640x480 -pix_fmt rgba -r 20.0 -i pipe: -vcodec h264 -pix_fmt yuv420p -y movie.mp4

instead of

MovieWriter.run: running command: ['ffmpeg', '-f', 'rawvideo', '-vcodec', 'rawvideo', '-s', '640x480', '-pix_fmt', 'rgba', '-r', '20.0', '-i', 'pipe:', '-vcodec', 'h264', '-pix_fmt', 'yuv420p', '-y', 'movie.mp4']

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Pretty-format subprocess logs.
06a9106 
e.g. subprocess spawned by the animation machinery are now logged as
```
MovieWriter._run: running command: ffmpeg -f rawvideo -vcodec rawvideo -s 640x480 -pix_fmt rgba -r 20.0 -i pipe: -vcodec h264 -pix_fmt yuv420p -y movie.mp4
```
instead of
```
MovieWriter.run: running command: ['ffmpeg', '-f', 'rawvideo', '-vcodec', 'rawvideo', '-s', '640x480', '-pix_fmt', 'rgba', '-r', '20.0', '-i', 'pipe:', '-vcodec', 'h264', '-pix_fmt', 'yuv420p', '-y', 'movie.mp4']
```
@tacaswell tacaswell added this to the v3.2.0 milestone Apr 26, 2019
@tacaswell tacaswell merged commit 9f7e624 into matplotlib:master Apr 26, 2019
@anntzer anntzer deleted the log-subprocess branch April 26, 2019 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @timhoffm @tacaswell