Deprecate checkdep_ps_distiller. #14046
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We may as well move it to the corresponding rc validator and always validate when assigning to that rcParam, not just at import time.
anntzer
commented
Apr 26, 2019
| @@ -534,11 +537,22 @@ def update_savefig_format(value): | |||
| def validate_ps_distiller(s): | |||
| if isinstance(s, str): | |||
| s = s.lower() | |||
| if s in ('none', None): | |||
| if s in ('none', None, 'false', False): | |||
There was a problem hiding this comment.
(these values are treated the same)
timhoffm
approved these changes
Apr 26, 2019
dstansby
reviewed
Apr 26, 2019
| Deprecations | ||
| ```````````` | ||
|
|
||
| ``matplotlib.checkdep_ps_distiller`` is deprecated. |
There was a problem hiding this comment.
Why is it deprecated? Is it useless, or is there an alternative to use instead?
There was a problem hiding this comment.
It is useless and undocumented.
Well of course you could be trying to use this to figure out whether a ps distiller that happens to match the ones that matplotlib supports is installed. In which case they can now just try to assign to rcParams["ps.usedistiller"] and see whether the setter complains. But frankly I just don't think it's a realistic use case and adding this to the changelog is essentially noise, I would say.
efiring
approved these changes
May 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We may as well move it to the corresponding rc validator and always
validate when assigning to that rcParam, not just at import time.
PR Summary
PR Checklist