Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add Yellowbrick to third party packages #14051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 26, 2019

Conversation

bbengfort
Copy link
Contributor

PR Summary

Adds a blurb and link about Yellowbrick to the documentation along with our README gallery image that shows some of the visualizers that Yellowbrick produces for classification, regression, and clustering.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please run the png trough a compressor like https://tinypng.com/. I don't want to unnecessarily bloat the repo and serve larger images than necessary to the user.

@bbengfort
Copy link
Contributor Author

Sure - I've resized and compressed the image.

Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

Just waiting for CI pass.

If someone else merges, please squash so that the original large image is squashed out.

@jklymak jklymak merged commit 6e49e89 into matplotlib:master Apr 26, 2019
@tacaswell tacaswell added this to the v3.1.0 milestone Apr 26, 2019
@tacaswell
Copy link
Member

@meeseeksdev backport to v3.1.x

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Apr 26, 2019
timhoffm added a commit that referenced this pull request Apr 26, 2019
…051-on-v3.1.x

Backport PR #14051 on branch v3.1.x (Add Yellowbrick to third party packages)
@QuLogic
Copy link
Member

QuLogic commented Apr 26, 2019

If someone else merges, please squash so that the original large image is squashed out.

@jklymak cough please be careful of this request in the future.

@jklymak
Copy link
Member

jklymak commented Apr 26, 2019

Ooops, sorry! Is there any way to revert and remove the offending commit?

@QuLogic
Copy link
Member

QuLogic commented Apr 27, 2019

No, the commits are public now. They could be removed but it's not nice to any forks and not really worth the effort in this case.

@jklymak
Copy link
Member

jklymak commented Apr 27, 2019

I promise to read full sentences in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants