FIX: do not try to manage the visibility of un-drawn ticks #14056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts part of the changes from matplotlib#13908 (in particular commit e908efe ) that tried to manage the visibility if the ticks that are not used. However, there was a bug in this that nothing would ever set ticks to be visible again. Because we currently cache / recycle ticks this meant that panning / zooming or resizing the figure would eventually lose ticks if the number of ticks ever went down and then back up. We could fix this by adding a `tick.set_visible(True)` for the drawn ticks, however this would break the (brittle) use case where users are reaching in and manually setting the visibility of individual ticks to False to hide them. Instead, we revert the consistency code altogether and accept that there will be `Tick` objects in `Axis.majorTicks` and `Axis.minorTicks` that are marked as visible, but are not drawn (because they are filtered by `_update_ticks`). Closes matplotlib#14054
jklymak
approved these changes
Apr 26, 2019
anntzer
approved these changes
Apr 29, 2019
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Apr 29, 2019
…y of un-drawn ticks
dstansby
added a commit
that referenced
this pull request
Apr 29, 2019
…056-on-v3.1.x Backport PR #14056 on branch v3.1.x (FIX: do not try to manage the visibility of un-drawn ticks)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts part of the changes from #13908 (in particular commit
e908efe ) that tried to manage the
visibility if the ticks that are not used. However, there was a bug
in this that nothing would ever set ticks to be visible
again. Because we currently cache / recycle ticks this meant that
panning / zooming or resizing the figure would eventually lose ticks
if the number of ticks ever went down and then back up.
We could fix this by adding a
tick.set_visible(True)for the drawnticks, however this would break the (brittle) use case where users are
reaching in and manually setting the visibility of individual ticks to
False to hide them.
Instead, we revert the consistency code altogether and accept that
there will be
Tickobjects inAxis.majorTicksandAxis.minorTicksthat are marked as visible, but are notdrawn (because they are filtered by
_update_ticks).Closes #14054
PR Summary
PR Checklist