Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Alternative fix for passing iterator as frames to FuncAnimation #14068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2019
Merged

Alternative fix for passing iterator as frames to FuncAnimation #14068

merged 1 commit into from
May 22, 2019

Conversation

timhoffm
Copy link
Member

@timhoffm timhoffm commented Apr 28, 2019 •
edited by efiring
Loading

PR Summary

Fixes #13676. Replaces #13679.

This was proposed in #13679 (comment) it's clearly the better approach as it's simpler and can handle generators. Thanks @anntzer.

I do not really know how to add a test for this. Can't have an infinite loop in a unittest 😄. Works fine as a standalone test with the following code

import matplotlib.pyplot as plt
import numpy as np
from matplotlib.animation import FuncAnimation

fig, ax = plt.subplots()
s = ax.set_title('0')
plt.plot([1,2,3],[2,4,3])
def update(frame):
    print(frame)
    s.set_text(str(frame))
    return []
animation = FuncAnimation(fig, update, frames=(i for i in range(5)), blit=True, interval=100)
plt.show()

@timhoffm timhoffm mentioned this pull request Apr 28, 2019
Closed
@timhoffm timhoffm added this to the v3.2.0 milestone Apr 28, 2019
@efiring efiring requested a review from dopplershift May 22, 2019 20:08
@efiring
Copy link
Member

efiring commented May 22, 2019

@dopplershift Would you like to have final say on this? It's a small and localized change.

dopplershift
dopplershift approved these changes May 22, 2019
View reviewed changes
Copy link
Contributor

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dopplershift dopplershift merged commit 56581cb into matplotlib:master May 22, 2019
@timhoffm timhoffm deleted the fix-funcantimation-frames-iter-repeat branch May 22, 2019 21:44
@anntzer anntzer mentioned this pull request Nov 5, 2020
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift dopplershift approved these changes

@anntzer anntzer anntzer approved these changes

Assignees
No one assigned
Labels
topic: animation
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.

FuncAnimation with generator causes crash on StopIteration
4 participants
@timhoffm @efiring @dopplershift @anntzer