Check number of positional arguments passed to quiver() #14084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
commented
Apr 29, 2019
| @@ -2148,16 +2148,6 @@ def _check_and_log_subprocess(command, logger, **kwargs): | |||
| return report | |||
|
|
|||
|
|
|||
| def _check_not_matrix(**kwargs): | |||
There was a problem hiding this comment.
This was only used in _parse_args, we don't check anywhere else in the code for np.matrix.
np.matrix itself is not recommended anymore and matplotlib usage: Types of inputs states that np.matrix may or may not work.
Therefore I don't see the need to explicitly check for this to give an error message.
Note also, this currently checked only U, V, C but not X, Y.
There was a problem hiding this comment.
This was added in #13089 to fix #1558 just in 3.1.0; do we really want to revert that check so quickly?
Also, skipping X and Y was done on purpose, though perhaps that's a little unintuitive.
anntzer
approved these changes
May 7, 2019
jklymak
approved these changes
May 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Inspired by looking into #14060, but another topic: The number of positional parameters passed to
quiver()was not properly validated.In case of just 1 parameter this results in a not quite helpful
IndexError: pop from empty list.In case of more than 5 parameters, the first 5 parameters are used and further parameters silently ignored.
This PR changes the behavior to always raise
TypeError: quiver() takes 2-5 positional arguments but {len_args} were given.Do we need an API change note for this or is this just a bug fix?
PR Checklist