Shorten _ImageBase._make_image. #14101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
reviewed
Apr 30, 2019
_ImageBase._make_image is a big, 267-line (+docstring) beast. Shorten it by ~20% by factoring out a helper for _image.resample (that takes care of allocating the output array), and with various small cleanups.
timhoffm
approved these changes
Apr 30, 2019
efiring
approved these changes
May 25, 2019
|
👍 And I even suspect that this got us a minor performance improvement! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_ImageBase._make_image is a big, 267-line (+docstring) beast. Shorten
it by ~20% by factoring out a helper for _image.resample (that takes
care of allocating the output array), and with various small cleanups.
PR Summary
PR Checklist