Fix glyph loading in textpath. #14156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 7, 2019
I missed the fact that `enc` is now a list, not a mapping anymore (and `glyph` is still an index), so the `glyph in enc` check does not make sense anymore. This fixes test_backend_svg::test_unicode_won, which previously failed *if run by itself* but curiously would not fail when run with the rest of the test suite.
timhoffm
approved these changes
May 7, 2019
jklymak
approved these changes
May 7, 2019
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
May 7, 2019
dstansby
added a commit
that referenced
this pull request
May 8, 2019
…156-on-v3.1.x Backport PR #14156 on branch v3.1.x (Fix glyph loading in textpath.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed the fact that
encis now a list, not a mapping anymore (andglyphis still an index), so theglyph in enccheck does not makesense anymore.
(Edit: looks like this was an incorrect last-minute partial revert after a review: #12928 (comment).)
This fixes test_backend_svg::test_unicode_won, which previously failed
if run by itself but curiously would not fail when run with the rest
of the test suite.
followup to #12928; I'm going to mark this as release critical as #12928 is basically wrong without this but feel free to untag.
there's a test in the followup PR, #14159.
PR Summary
PR Checklist