Remove APIs deprecated in mpl3.0. #14244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fb5e6c6 to
0481712
Compare
timhoffm
reviewed
May 19, 2019
| @@ -4457,13 +4457,6 @@ def scatter(self, x, y, s=None, c=None, marker=None, cmap=None, norm=None, | |||
|
|
|||
| scales = s # Renamed for readability below. | |||
|
|
|||
| # to be API compatible | |||
| if verts is not None: | |||
There was a problem hiding this comment.
verts should be be removed from the method signature. Unfortunately, strictly speaking this would be a breaking change again because you change the position of edgecolors. But nevertheless I think that's what we should do - and since edgecolors is changing its position anyway, you can move the kwonly marker * before it.
The alternative would be to keep verts and raise a TypeError here.
There was a problem hiding this comment.
I added a _delete_parameter on verts. Sure, that'll take two more minor versions before removing it from the signature, but heh, there's no urgency either...
| "simultaneously. " | ||
| "Please only use 'density', since 'normed'" | ||
| "is deprecated.") | ||
| if normed is not None: |
317f39b to
dea307f
Compare
dea307f to
4930fbc
Compare
timhoffm
approved these changes
May 22, 2019
6 tasks
This was referenced Oct 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Checklist