-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
DOC: add note to example about keeping hard-ref to SpanSelector #14285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This doesn't seem to have the desired effect: https://21369-1385122-gh.circle-artifacts.com/0/home/circleci/project/doc/build/html/gallery/widgets/span_selector.html But even if the "note"-box appeared, would you want it to cut the code in half? Maybe use normal inline comments? Or put the note outside the code, such that it is still copy-pastable as a single entity? Btw. I guess this note would then need to appear in all the widget examples? |
As argued in #10876 (comment) / #10908 (comment) I think CallbackRegistry should just keep strong references... |
I was trying to cut the code in half, but will go back to just in-line comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tacaswell ! This looks good to me.
@tacaswell Let me know when you fix the rendering issue? |
…hard-ref to SpanSelector
…hard-ref to SpanSelector
@timhoffm Does merging this mean that you will take the responsibility to make sure the note actually appears in a future PR? |
It was an improvement in any case. I'm sure someone will at some point see this, and open a PR to fix it. |
@ImportanceOfBeingErnest I was a bit quick. Assuming you mean #14422. |
…285-on-v3.1.0-doc Backport PR #14285 on branch v3.1.0-doc (DOC: add note to example about keeping hard-ref to SpanSelector)
…285-on-v3.1.x Backport PR #14285 on branch v3.1.x (DOC: add note to example about keeping hard-ref to SpanSelector)
closes #14276
PR Summary
PR Checklist