BUG: Fix performance regression when plotting values from Numpy array sub-classes #14289
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This fixes the issue described in #14274 that plotting with Astropy Quantities is now very slow in Matplotlib 3.1.0.
Note that given the existing test, the code could have even been written as:
so I've also added a more involved test to make sure that what #11921 was trying to fix still works, as well as a regression test for #14274
cc @anntzer and @jklymak
PR Checklist