Fix test_imshow_pil on Windows. #14419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test_imshow_pil currently fails on Windows, but this was not detected because PIL is not installed on the Appveyor CI so the test is skipped.
timhoffm
approved these changes
Jun 2, 2019
jkseppan
approved these changes
Jun 7, 2019
|
Is there a reason that we don't install PIL on Appveyor, or could it be added in .appveyor.yml? |
|
I think originally because the appveyor tests were extremely slow and a real bottleneck. |
|
Right, I remember that the Appveyor tests were really slow at some time. Obviously we can’t test every combination of dependencies.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_imshow_pil currently fails on Windows, but this was not detected
because PIL is not installed on the Appveyor CI so the test is skipped.
Noted while working on #13077.
The Pillow issue is python-pillow/Pillow#3823.
PR Summary
PR Checklist