Rewrite an argument check to _check_getitem #14565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
reviewed
Jun 18, 2019
anntzer
approved these changes
Jun 19, 2019
6 tasks
12867ba to
0e29b47
Compare
0e29b47 to
a921be8
Compare
|
rebased. |
jklymak
approved these changes
Jul 25, 2019
|
Prob not worth API note... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #14564.
Any
sci*was accepted equivalently tosci. I'm daring to drop this and only allowsciandscientificas mentioned in the docs. Technically, this is an API change, but I don't think it's worth the noise of a deprecation or API change note. But that's why I just go for 3.2 not 3.1.2.