Make ticklabel_format work both for 2D and 3D axes. #14575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
Jul 4, 2019
QuLogic
reviewed
Jul 17, 2019
d8ab67e to
5d11694
Compare
|
Needs tests? |
5d11694 to
c539736
Compare
|
test's in |
|
No 3D tests? This is labelled |
... instead of duplicating its implementation in axes3d with just minor changes. Note that ticklabel_format was not used anywhere either in the tests or in the examples. Exercise it in the scalarformatter example, which also gets slightly updated -- ScalarFormatter has been the default formatter for years, so doesn't really warrant the label "The new formatter".
|
fair enough, moved the test to test_mplot3d |
c539736 to
7cf9bba
Compare
QuLogic
approved these changes
Jul 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... instead of duplicating its implementation in axes3d with just minor
changes.
Note that ticklabel_format was not used anywhere either in the tests or
in the examples. Exercise it in the scalarformatter example, which also
gets slightly updated -- ScalarFormatter has been the default formatter
for years, so doesn't really warrant the label "The new formatter".
PR Summary
PR Checklist