Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove the private Tick._name attribute. #14630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 29, 2019
Merged

Remove the private Tick._name attribute. #14630

merged 1 commit into from
Jun 29, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jun 25, 2019

It's only used in two places and is trivially inlined there.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Remove the private Tick._name attribute.
e0cfd0c 
It's only used in two places and is trivially inlined there.
@timhoffm timhoffm added this to the v3.2.0 milestone Jun 29, 2019
@timhoffm timhoffm merged commit b9d0af7 into matplotlib:master Jun 29, 2019
@anntzer anntzer deleted the nameless branch June 29, 2019 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
topic: ticks axis labels
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @QuLogic @timhoffm