Remove reference to old Tk/Windows bug. #14632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See patch. At least I can't repro it on Windows, and you'd expect it to be semi-regularly reported on the tracker if it still occurred. In the example, don't bother calling `root.destroy()`, as `root.quit()` already handles the destroying (both on Linux and Windows, an additional call to `root.destroy()` results in "can't invoke "destroy" command: application has been destroyed").
timhoffm
approved these changes
Jun 29, 2019
tacaswell
approved these changes
Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See patch.
At least I can't repro it on Windows, and you'd expect it to be
semi-regularly reported on the tracker if it still occurred.
In the example, don't bother calling
root.destroy(), asroot.quit()already handles the destroying (both on Linux and Windows, an additional
call to
root.destroy()results in "can't invoke "destroy" command:application has been destroyed").
PR Summary
PR Checklist