Fix bug when setting negative limits and using log scale #14635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
reviewed
Jun 26, 2019
lib/matplotlib/axes/_base.py
Outdated
| @@ -3240,10 +3240,11 @@ def set_xlim(self, left=None, right=None, emit=True, auto=False, | |||
| left = self._validate_converted_limits(left, self.convert_xunits) | |||
| right = self._validate_converted_limits(right, self.convert_xunits) | |||
|
|
|||
| old_left, old_right = self.get_xlim() | |||
|
|
|||
| if left is None or right is None: | |||
| # Axes init calls set_xlim(0, 1) before get_xlim() can be called, | |||
| # so only grab the limits if we really need them. | |||
There was a problem hiding this comment.
Given the comment here, I'd assume that this actually needs to stay here (... for init order purposes) and you need to duplicate the call to get_xlim() under if self.get_xscale("log"): ...?
There was a problem hiding this comment.
Oops yes, I've fixed that
3fc50c7 to
94ac78a
Compare
anntzer
reviewed
Jun 26, 2019
| @@ -3249,7 +3249,10 @@ def set_xlim(self, left=None, right=None, emit=True, auto=False, | |||
| if right is None: | |||
| right = old_right | |||
|
|
|||
| if self.get_xscale() == 'log': | |||
| if self.get_xscale() == 'log' and (left <= 0 or right <= 0): | |||
There was a problem hiding this comment.
likely the same is needed for set_ylim?
|
I'm investigating the test failures |
bbe2147 to
e71f881
Compare
|
@anntzer - I think this is ready for a final review. The AppVeyor failure seems to be unrelated. |
anntzer
approved these changes
Jun 27, 2019
|
Milestoning as 3.2 as I think the bug is only on master? |
|
@anntzer - I didn't run into the issue with older versions so I think 3.2 makes sense. |
timhoffm
approved these changes
Jun 30, 2019
timhoffm
approved these changes
Jun 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue that caused the following error when setting negative limits on a log plot: