FIX: allow secondary axes to be non-linear #14640
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes an issue on gitter by @Tillsten whereby the secondary_axes doesn't do ticks properly for non-linear axes.
The issue here is that we really need to use the inverse to position ticks, not the forward function:
Before
This is what we would want a sqrt(x) scale to normally look like....
After
... but for a secondary axis we want the values to match up, so we really need to specify the position with the inverse:
PR Checklist