Simplify _process_plot_var_args. #14641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The unit handling at the top of `__call__` is duplicated with `Axes._process_unit_info`, so just use that. - The conditional call to `convert_xunits` in `_xy_from_xy` can be moved to `_makefill` (the only case where it's needed), and made non-conditional (if `x` is not unitized, `convert_xunits` will just return it as is). - The rest of `_xy_from_xy` can be inlined into its only call site (`_plot_args`) which also makes clear that the calls to `_check_1d` are redundant because the caller already calls `_check_1d` (possibly via `index_of`) immediately before.
b3fe08d to
4da5bc1
Compare
timhoffm
approved these changes
Jun 29, 2019
jklymak
approved these changes
Jul 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__call__is duplicated withAxes._process_unit_info, so just use that.convert_xunitsin_xy_from_xycanbe moved to
_makefill(the only case where it's needed), and madenon-conditional (if
xis not unitized,convert_xunitswill justreturn it as is).
_xy_from_xycan be inlined into its only call site(
_plot_args) which also makes clear that the calls to_check_1dare redundant because the caller already calls
_check_1d(possiblyvia
index_of) immediately before.PR Summary
PR Checklist