Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove some unnecessary prints from setup.py. #14653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2019
Merged

Remove some unnecessary prints from setup.py. #14653

merged 1 commit into from
Jul 2, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jun 29, 2019

  • Instead of populating required_failed, we can just immediately fail
    when a component fails to build. (Actually there is no case where
    this can happen -- no required package ever throws CheckFailed --
    but I'll further unravel that code in a later PR...)
  • Then print_line becomes used in a single place (at the top of the
    build); using an empty line works just as well.
  • Then print_message and print_line becomes no longer used and can be
    deleted.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Remove some unnecessary prints from setup.py.
6e73fbf 
- Instead of populating required_failed, we can just immediately fail
  when a component fails to build.  (Actually there is no case where
  this can happen -- no required package ever throws CheckFailed --
  but I'll further unravel that code in a later PR...)
- Then print_line becomes used in a single place (at the top of the
  build); using an empty line works just as well.
- Then print_message and print_line becomes no longer used and can be
  deleted.
@anntzer anntzer added the Build label Jun 29, 2019
@tacaswell tacaswell added this to the v3.2.0 milestone Jul 2, 2019
@tacaswell
Copy link
Member

Hopefully no one is screen-scraping our output...

@tacaswell tacaswell merged commit 32231f2 into matplotlib:master Jul 2, 2019
@anntzer anntzer deleted the setupprint branch July 2, 2019 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Build
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @tacaswell @timhoffm