Cleanup of docstrings of scales #14654
Conversation
| @@ -100,8 +107,8 @@ def set_default_locators_and_formatters(self, axis): | |||
|
|
|||
| def get_transform(self): | |||
| """ | |||
| The transform for linear scaling is just the | |||
| :class:`~matplotlib.transforms.IdentityTransform`. | |||
| Return the transform for linear scaling, which is just the | |||
There was a problem hiding this comment.
just inherit all these docstrings? not sure per-scale documentation of get_transform is really useful.
There was a problem hiding this comment.
For now, I'd leave it. There's a bit of value to have the link to the respective transform in the subclasses. Alternatively, one could document these relations for the builtin scales in a common place. and eliminate most of the get_transforms. Almost all are just returning self._transform. But that's for another time. You are welcome to make a PR (after this is merged 😉).
a9875dc to
b653f5f
Compare
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
|
Not bothering to backport as 3.2 is approaching. |
PR Summary