Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Artist tutorial fixes #14672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 2, 2019
Merged

Artist tutorial fixes #14672

merged 3 commits into from
Jul 2, 2019

Conversation

bingyao
Copy link
Contributor

@bingyao bingyao commented Jul 2, 2019

PR Summary

  • Commit 6f060eb: Fixed code ref. ~matplotlib.image.Image
  • Commit 6002943: (with matplotlib 3.1.0) rect.get_axes() produce an Error, change to rect. axes
  • Commit da8ccdc: Fixed some formatting issues in Axis containers part.

tacaswell
tacaswell approved these changes Jul 2, 2019
View reviewed changes
Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modulo CI

@tacaswell
Copy link
Member

Thanks @bingyao ! Looks good to me, but want to wait for CI to pass before merging.

@tacaswell tacaswell added this to the v3.2.0 milestone Jul 2, 2019
@timhoffm timhoffm merged commit 04d9d28 into matplotlib:master Jul 2, 2019
@bingyao bingyao deleted the artist_tutorial_fixes branch July 8, 2019 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bingyao @tacaswell @timhoffm