Confluence builder in plot directive #14681
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jjcaballero <[email protected]>
Signed-off-by: jjcaballero <[email protected]>
tacaswell
approved these changes
Jul 3, 2019
|
Does everything else build as expected with the confluence builder? |
6 tasks
|
Perhaps #14683 is a worthwhile alternative approach? |
|
Temporarily closing in favor of #14683 . If the confluence backend can not be made to support selecting it's preferred format we can re-address this. |
|
Thank you for your work on this @jjcaballero ! |
|
@tacaswell No problem, it makes sense. The alternative is more general #14683, I will look into the confluence builder to handle the *. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Added "confluence" as a possible builder in plot_directive.py.
This allows using matplotlib with this sphinx extension: https://github.com/sphinx-contrib/confluencebuilder
The images were already properly generated, the only pending thing was to consider confluence as a builder and then add the images within the template.
PR Checklist